fix: login return_url doesn't work with custom server paths #21588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
nitishfy
approved these changes
Jan 21, 2025
gdsoumya
approved these changes
Jan 21, 2025
|
/cherry-pick release-2.13 |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
6 tasks
dudo
pushed a commit
to dudo/argo-cd
that referenced
this pull request
Jan 25, 2025
…#21588) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Brett C. Dudo <brett@dudo.io>
This was referenced Feb 14, 2025
3 tasks
vasilegroza
pushed a commit
to vasilegroza/argo-cd
that referenced
this pull request
Feb 27, 2025
…#21588) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21432
Login page redirects to return URL history API. The history API automatically appends base path, so it has to be removed from the return URL before redirect
Screen.Recording.2025-01-20.at.7.59.58.PM.mov