Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support managing cluster with multiple argocd instances and annotation based tracking (#20222) #20483

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Oct 21, 2024

Cherry-picks #20222 into 2.13

…tation based tracking (argoproj#20222)

Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@alexmt alexmt requested review from a team as code owners October 21, 2024 20:24
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 54.16667% with 55 lines in your changes missing coverage. Please review.

Project coverage is 54.97%. Comparing base (8340e1e) to head (015abb2).
Report is 40 commits behind head on release-2.13.

Files with missing lines Patch % Lines
util/kube/kube.go 38.88% 9 Missing and 2 partials ⚠️
controller/state.go 60.00% 6 Missing and 2 partials ⚠️
util/webhook/webhook.go 12.50% 6 Missing and 1 partial ⚠️
util/argo/argo.go 25.00% 5 Missing and 1 partial ⚠️
util/argo/resource_tracking.go 64.70% 4 Missing and 2 partials ⚠️
controller/sync.go 33.33% 3 Missing and 1 partial ⚠️
controller/cache/cache.go 50.00% 2 Missing and 1 partial ⚠️
reposerver/cache/cache.go 81.25% 3 Missing ⚠️
server/application/application.go 40.00% 2 Missing and 1 partial ⚠️
util/settings/settings.go 50.00% 2 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.13   #20483      +/-   ##
================================================
- Coverage         54.98%   54.97%   -0.02%     
================================================
  Files               320      320              
  Lines             54514    54601      +87     
================================================
+ Hits              29976    30017      +41     
- Misses            21972    22007      +35     
- Partials           2566     2577      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishitasequeira ishitasequeira merged commit be57dfe into argoproj:release-2.13 Oct 22, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants