Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure DevOps Self-signed certs #20046

Closed

Conversation

arnouthoebreckx
Copy link

@arnouthoebreckx arnouthoebreckx commented Sep 21, 2024

Fixes ISSUE #9607 but for Azure DevOps

Issue was created for BitBucket but in the comments discussions were made to create the same for other providers. Azure DevOps also has a less popular version of Azure DevOps Server that can be installed on-premise with self-signed certificates.

Was based on a previously merged PR #19002 that did the same for BitBucketServer & GitLab.

Checklist:

[ x ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
[ x ] The title of the PR states what changed and the related issues number (used for the release note).
[ x ] The title of the PR conforms to the Toolchain Guide
[ x ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
[ x ] Does this PR require documentation updates?
[ x ] I've updated documentation as required by this PR.
[ x ] I have signed off all my commits as required by DCO
I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
My build is green (troubleshooting builds).
My new feature complies with the feature status guidelines.
I have added a brief description of why this PR is necessary and/or what this PR solves.
Optional. My organization is added to USERS.md.
Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@arnouthoebreckx arnouthoebreckx requested review from a team as code owners September 21, 2024 11:42
Copy link

bunnyshell bot commented Sep 21, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Sep 21, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@40c6077). Learn more about missing BASE report.
Report is 436 commits behind head on master.

Files with missing lines Patch % Lines
applicationset/generators/scm_provider.go 0.00% 9 Missing ⚠️
applicationset/generators/pull_request.go 0.00% 7 Missing ⚠️
...plicationset/services/pull_request/azure_devops.go 0.00% 3 Missing ⚠️
...plicationset/services/scm_provider/azure_devops.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20046   +/-   ##
=========================================
  Coverage          ?   55.78%           
=========================================
  Files             ?      320           
  Lines             ?    44414           
  Branches          ?        0           
=========================================
  Hits              ?    24776           
  Misses            ?    17078           
  Partials          ?     2560           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant