Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update argocd-redis-deployment.yaml #18966

Closed
wants to merge 8 commits into from

Conversation

nulluuid
Copy link

@nulluuid nulluuid commented Jul 6, 2024

Fix Podman: Failed to inspect image "redis:7.0.15-alpine": rpc error: code = Unknown desc = short-name "redis:7.0.15-alpine" did not resolve to an alias and no unqualified-search registries are defined in "/etc/containers/registries.conf"

More information here https://unix.stackexchange.com/questions/701784/podman-no-longer-searches-dockerhub-error-short-name-did-not-resolve-to-an

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Fix Podman: Failed to inspect image "redis:7.0.15-alpine": rpc error: code = Unknown desc = short-name "redis:7.0.15-alpine" did not resolve to an alias and no unqualified-search registries are defined in "/etc/containers/registries.conf"

Signed-off-by: nulluuid <156840743+nulluuid@users.noreply.github.com>
@nulluuid nulluuid requested a review from a team as a code owner July 6, 2024 08:30
Copy link

bunnyshell bot commented Jul 6, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link

bunnyshell bot commented Jul 6, 2024

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@fengshunli
Copy link
Member

add fix title

Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good contribution, that's frustrating.

@todaywasawesome todaywasawesome enabled auto-merge (squash) July 17, 2024 15:33
@pasha-codefresh pasha-codefresh changed the title Update argocd-redis-deployment.yaml chore: Update argocd-redis-deployment.yaml Jul 17, 2024
@pasha-codefresh
Copy link
Member

please run make codegen and commit the changes

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault requested a review from a team as a code owner August 22, 2024 16:39
Copy link
Member

@agaudreault agaudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The e2e seems to fail because the new image needs to be pulled in the Github workflow, but that file must be on master afaik. @crenshaw-dev do you think it is safe to merge?

ARGOCD_IN_CI: 'true'
ARGOCD_E2E_APISERVER_PORT: '8088'
ARGOCD_APPLICATION_NAMESPACES: 'argocd-e2e-external,argocd-e2e-external-2'
ARGOCD_SERVER: '127.0.0.1:8088'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all quotes replaced? Is this standard for Yaml?

@sveno1990 sveno1990 mentioned this pull request Mar 10, 2025
14 tasks
@nitishfy
Copy link
Member

No response from author, closing this. Feel free to reopen.

@nitishfy nitishfy closed this Mar 11, 2025
auto-merge was automatically disabled March 11, 2025 15:40

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants