chore: bump argo-ui version #13836
Merged
chore: bump argo-ui version #13836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blakepettersson can you check the UI build failure? |
blakepettersson
force-pushed
the
chore/bump-argo-ui-version
branch
from
529bd10 to
62524e1
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #13836 +/- ##
=======================================
Coverage 49.48% 49.48%
=======================================
Files 256 256
Lines 43847 43841 -6
=======================================
- Hits 21697 21695 -2
+ Misses 19988 19985 -3
+ Partials 2162 2161 -1 ☔ View full report in Codecov by Sentry. |
|
@crenshaw-dev I needed to pin |
We need to add `@types/uuid` as a dev dependency, and we also need to update `argo-ui`, since it was pulling in a newer version of `react-toastify`. My fork pins it to `9.0.8`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Bump the argo-ui version to get the version which corresponds with the latest `master`, containing argoproj/argo-ui#379. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
blakepettersson
force-pushed
the
chore/bump-argo-ui-version
branch
from
62524e1 to
40e7e60
Compare
|
@blakepettersson did you have a chance to spin it up locally, just to make sure there's no obvious breakage? If not, I'll give it a try this evening. Preview environments would be great for this stuff. 🙂 |
|
@crenshaw-dev I did, but feel free to try it out on your end as well.Preview environments would definitely be a good thing. 😄 |
crenshaw-dev
approved these changes
Jun 3, 2023
crenshaw-dev
approved these changes
Jun 3, 2023
3 tasks
yyzxw
pushed a commit
to yyzxw/argo-cd
that referenced
this pull request
Aug 9, 2023
* fix: update deps We need to add `@types/uuid` as a dev dependency, and we also need to update `argo-ui`, since it was pulling in a newer version of `react-toastify`. My fork pins it to `9.0.8`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * build: regenerate lockfile Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: bump argo-ui version Bump the argo-ui version to get the version which corresponds with the latest `master`, containing argoproj/argo-ui#379. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
tesla59
pushed a commit
to tesla59/argo-cd
that referenced
this pull request
Dec 16, 2023
* fix: update deps We need to add `@types/uuid` as a dev dependency, and we also need to update `argo-ui`, since it was pulling in a newer version of `react-toastify`. My fork pins it to `9.0.8`. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * build: regenerate lockfile Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> * chore: bump argo-ui version Bump the argo-ui version to get the version which corresponds with the latest `master`, containing argoproj/argo-ui#379. Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the argo-ui version to get the version which corresponds with the latest
master, containing argoproj/argo-ui#367.Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Please see Contribution FAQs if you have questions about your pull-request.