Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sticking to DNS label standard in branch_slug (Gitlab PR Generators) #10801

Closed
wants to merge 3 commits into from

Conversation

Aym3nTN
Copy link
Contributor

@Aym3nTN Aym3nTN commented Oct 5, 2022

#10622

Building on top of this PR #10698 (not sure if it's the right to do it though)

I had to fix these 2 issues in the gosimple/slug package: gosimple/slug#77 and gosimple/slug#75

link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

cleverhu and others added 2 commits September 26, 2022 19:57
Fixes: argoproj#10622
Signed-off-by: cleverhu <shouping.hu@daocloud.io>
Signed-off-by: Aymen Ben Tanfous <aymen.bentanfous@gmail.com>
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.67%. Comparing base (53a210e) to head (8ba5c3a).
Report is 2482 commits behind head on master.

Files Patch % Lines
applicationset/generators/pull_request.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10801   +/-   ##
=======================================
  Coverage   45.67%   45.67%           
=======================================
  Files         236      236           
  Lines       28697    28702    +5     
=======================================
+ Hits        13106    13109    +3     
- Misses      13799    13800    +1     
- Partials     1792     1793    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Aym3nTN
Copy link
Contributor Author

Aym3nTN commented Oct 5, 2022

@crenshaw-dev is it possible to pick this on v2.5 release with this ticket? #9540 (comment)

Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Aym3nTN! I proposed an alternative solution here: #10622 (comment)

@crenshaw-dev crenshaw-dev mentioned this pull request Oct 7, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants