Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgoCD: Logs tab is not visible in latest version of ArgoCD #9231

Closed
nikhleshgoenka opened this issue Apr 27, 2022 · 10 comments · Fixed by #9257
Closed

ArgoCD: Logs tab is not visible in latest version of ArgoCD #9231

nikhleshgoenka opened this issue Apr 27, 2022 · 10 comments · Fixed by #9257
Assignees
Labels
bug Something isn't working

Comments

@nikhleshgoenka
Copy link

Checklist:

  • [Yes ] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • [Yes ] I've included steps to reproduce the bug.
  • [Yes ] I've pasted the output of argocd version.

Describe the bug

Logs tab is not visible which used to come before. This is broken with latest tag of ArgoCD

To Reproduce

Click on the pod kind and observe the pop-up.

Expected behavior

Logs tab should be visible for Pods.

Screenshots

ArgoCD

Version

{
    "Version": "v2.4.0+5f0e58d",
    "BuildDate": "2022-04-27T17:34:43Z",
    "GitCommit": "5f0e58d5f0678a0ca545c82a0f0ed060fdf648d3",
    "GitTreeState": "clean",
    "GoVersion": "go1.18.1",
    "Compiler": "gc",
    "Platform": "linux/amd64",
    "KustomizeVersion": "v4.4.1 2021-11-11T23:36:27Z",
    "HelmVersion": "v3.8.1+g5cb9af4",
    "KubectlVersion": "v0.23.1",
    "JsonnetVersion": "v0.18.0"
}

Logs

NA
@nikhleshgoenka nikhleshgoenka added the bug Something isn't working label Apr 27, 2022
@todaywasawesome
Copy link
Contributor

@nikhleshgoenka I'm seriously confused. Your Argo CD version is v2.4.0+5f0e58d but the current version is v2.3.3+07ac038

Also argocd version doesn't output like that. It looks like this:

 argocd version                      
argocd: v2.3.3+07ac038.dirty
  BuildDate: 2022-03-30T05:14:36Z
  GitCommit: 07ac038a8f97a93b401e824550f0505400a8c84e
  GitTreeState: dirty
  GoVersion: go1.18
  Compiler: gc
  Platform: darwin/arm64
argocd-server: v2.3.3+07ac038```

@crenshaw-dev
Copy link
Member

crenshaw-dev commented Apr 27, 2022

Maybe related to #9226

Edit: nope, it was this one: #9219

@nikhleshgoenka
Copy link
Author

nikhleshgoenka commented Apr 28, 2022

@todaywasawesome @crenshaw-dev I’ve pulled my ArgoCD HA manifests from the master branch and whenever I restart my pods it keeps taking the latest builds.

Output what I gave comes from ArgoCD UI, it gives a JSON which comes when I click the ArgoCD logo. So is it a bug in ArgoCD UI vs CLI?

Here is the output from CLI:

argocd version
argocd: v2.0.5+4c94d88
  BuildDate: 2021-07-22T20:52:31Z
  GitCommit: 4c94d886f56bcb2f9d5b3251fdc049c2d1354b88
  GitTreeState: clean
  GoVersion: go1.16
  Compiler: gc
  Platform: linux/amd64
argocd-server: v2.4.0+5f0e58d

UI Output Snip:

ArgoCDUIVersion

@jannfis
Copy link
Member

jannfis commented Apr 28, 2022

Also, live manifests for pods (and some but not all other resources that were created as children of resources in manifests) are not showing in the UI.

@jannfis
Copy link
Member

jannfis commented Apr 28, 2022

Screenshot from cd.apps.argoproj.io:

A pod:

image

ReplicaSet seems to be ok:

image

Service does not show, even though it's managed:

image

@jannfis
Copy link
Member

jannfis commented Apr 28, 2022

Seems the resource endpoint throws an Error 500:

image

@jannfis
Copy link
Member

jannfis commented Apr 28, 2022

Some more information, apparently something has changed and the call is now invalid:

$ curl -v "http://127.0.0.1:4000/api/v1/applications/guestbook/resource?name=kustomize-guestbook-ui-779bc8b498-mgx98&namespace=guestbook-test&resourceName=kustomize-guestbook-ui-779bc8b498-mgx98&version=v1&kind=Pod"
*   Trying 127.0.0.1...
* TCP_NODELAY set
* Connected to 127.0.0.1 (127.0.0.1) port 4000 (#0)
> GET /api/v1/applications/guestbook/resource?name=kustomize-guestbook-ui-779bc8b498-mgx98&namespace=guestbook-test&resourceName=kustomize-guestbook-ui-779bc8b498-mgx98&version=v1&kind=Pod HTTP/1.1
> Host: 127.0.0.1:4000
> User-Agent: curl/7.61.1
> Accept: */*
> 
< HTTP/1.1 500 Internal Server Error
< X-Powered-By: Express
< content-type: application/json
< date: Thu, 28 Apr 2022 11:27:46 GMT
< content-length: 173
< connection: close
< Vary: Accept-Encoding
< 
* Closing connection 0
{"error":"grpc: error while marshaling: proto: required field \"group\" not set","code":13,"message":"grpc: error while marshaling: proto: required field \"group\" not set"}

@crenshaw-dev
Copy link
Member

Linked the wrong issue above. Guessing it's related to this: #9219

I think it's related to the GRPC update: #8929

Looks like group used to be optional, but now it's not.

Closing the other issue in favor of this, since there's more detail here.

@jannfis
Copy link
Member

jannfis commented Apr 28, 2022

Right, this is supposedly a regression introduced by #8929, I tested locally on a commnit previous to it and it works, and the commit with the gRPC update apparently broke it.

@todaywasawesome
Copy link
Contributor

@nikhleshgoenka Yes, this is a bug in 2.4 that is preventing release, @crenshaw-dev and @jannfis are correct. I don't know if your intention was to test pre-release versions but you should deploy a specific version when installing unless you're trying specifically to test pre-release versions. https://github.com/argoproj/argo-cd/releases/tag/v2.3.3

For the moment I think we should close this issue as it's part of #8929 and opening bugs on pre-release doesn't really make sense.

crenshaw-dev added a commit to crenshaw-dev/argo-cd that referenced this issue Apr 29, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
crenshaw-dev added a commit that referenced this issue May 3, 2022
* fix(ui): missing manifests and logs (#9231)

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* more group fixes

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
alexmt pushed a commit that referenced this issue May 6, 2022
* fix(ui): missing manifests and logs (#9231)

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* feat: make exec feature opt-in

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* fix codegen

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* use create instead of get for exec to match k8s

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* add RBAC instructions for exec

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* delete old line

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* remove unnecessary caveat

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants