Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server-side diff always misses diff cache #20423

Closed
crenshaw-dev opened this issue Oct 17, 2024 · 0 comments · Fixed by #20424
Closed

Server-side diff always misses diff cache #20423

crenshaw-dev opened this issue Oct 17, 2024 · 0 comments · Fixed by #20424
Labels
bug Something isn't working server-side-diff

Comments

@crenshaw-dev
Copy link
Member

Describe the bug

After enabling server-side diff, I encounter costly diffing with debug logs showing sudeDiffCache: false because specChanged.

To Reproduce

Enable server-side diff and set timeout.reconciliation to a low value (I did 1s). Make sure debug logs are enabled.

Expected behavior

I expect diff caches to avoid constant k8s API calls for diffing.

Version

master branch, but probable applies to every version with server-side diff.

Originally reported here: https://cloud-native.slack.com/archives/C01TSERG0KZ/p1727279208491509
@crenshaw-dev crenshaw-dev added bug Something isn't working server-side-diff labels Oct 17, 2024
crenshaw-dev added a commit to crenshaw-dev/argo-cd that referenced this issue Oct 17, 2024
@crenshaw-dev
fix(diff): avoid cache miss in server-side diff (argoproj#20423)
0070a14 
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev mentioned this issue Oct 17, 2024
Merged
@crenshaw-dev crenshaw-dev changed the title Servier-side diff always misses diff cache Server-side diff always misses diff cache Oct 17, 2024
crenshaw-dev added a commit that referenced this issue Oct 18, 2024
@crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20423) (#20424)
ec499bb 
* fix(diff): avoid cache miss in server-side diff (#20423)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix silly mistakes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Oct 18, 2024
@crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20423) (#20424)
c3ad9c8 
* fix(diff): avoid cache miss in server-side diff (#20423)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix silly mistakes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Oct 18, 2024
@crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20423) (#20424)
f489e12 
* fix(diff): avoid cache miss in server-side diff (#20423)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix silly mistakes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
This was referenced Oct 18, 2024
Merged
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Oct 18, 2024
@crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20423) (#20424)
bc7c092 
* fix(diff): avoid cache miss in server-side diff (#20423)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix silly mistakes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Oct 18, 2024
Merged
crenshaw-dev added a commit that referenced this issue Oct 18, 2024
@gcp-cherry-pick-bot @crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20423) (#20424) (#2…
5c595d8 
…0449)

* fix(diff): avoid cache miss in server-side diff (#20423)



* fix silly mistakes



---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this issue Oct 18, 2024
@gcp-cherry-pick-bot @crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20423) (#20424) (#2…
68f63e7 
…0450)

* fix(diff): avoid cache miss in server-side diff (#20423)



* fix silly mistakes



---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
crenshaw-dev added a commit that referenced this issue Oct 18, 2024
@gcp-cherry-pick-bot @crenshaw-dev
fix(diff): avoid cache miss in server-side diff (#20423) (#20424) (#2…
d758ac8 
…0451)

* fix(diff): avoid cache miss in server-side diff (#20423)



* fix silly mistakes



---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
adriananeci pushed a commit to adriananeci/argo-cd that referenced this issue Dec 4, 2024
@crenshaw-dev @adriananeci
fix(diff): avoid cache miss in server-side diff (argoproj#20423) (arg…
ce5c00e 
…oproj#20424)

* fix(diff): avoid cache miss in server-side diff (argoproj#20423)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

* fix silly mistakes

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>

---------

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Adrian Aneci <aneci@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working server-side-diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(diff): avoid cache miss in server-side diff (#20423) crenshaw-dev/argo-cd
1 participant
@crenshaw-dev