fix: Helm v3 CRD are not deployed (#3345)

* Fixing could not find plugin issue when app sync and app diff

* Fixing codegen error

* Revert "Fixing codegen error"

This reverts commit b2dcfb8

* Fixing codegen error

* If user is logged in, settings API would return ConfigManagementPlugins

* For helm3, add flag --include-crds when calling helm template to support helm3 crd

* Fixing typo.

* Added further assertion of ResourceSyncStatusIs for CRD resources.

test/e2e/helm_test.go

@@ -290,3 +290,14 @@ func testHelmWithDependencies(t *testing.T, chartPath string, legacyRepo bool) {
 		Then().
 		Expect(SyncStatusIs(SyncStatusCodeSynced))
 }
+
+func TestHelm3CRD(t *testing.T) {
+	Given(t).
+		Path("helm3-crd").
+		When().
+		Create().
+		Sync().
+		Then().
+		Expect(SyncStatusIs(SyncStatusCodeSynced)).
+		Expect(ResourceSyncStatusIs("CustomResourceDefinition", "crontabs.stable.example.com", SyncStatusCodeSynced))
+}

test/e2e/testdata/helm3-crd/Chart.yaml

@@ -0,0 +1,6 @@
+apiVersion: v2
+name: argocd-helm3-crd
+description: A Helm chart for Kubernetes
+type: application
+version: 0.1.0
+appVersion: 1.16.0

test/e2e/testdata/helm3-crd/crds/crd.yaml

@@ -0,0 +1,14 @@
+apiVersion: apiextensions.k8s.io/v1beta1
+kind: CustomResourceDefinition
+metadata:
+  name: crontabs.stable.example.com
+spec:
+  group: stable.example.com
+  version: v1
+  scope: Namespaced
+  names:
+    plural: crontabs
+    singular: crontab
+    kind: CronTab
+    shortNames:
+      - ct

test/e2e/testdata/helm3-crd/templates/config-map.yaml

@@ -0,0 +1,6 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: my-map
+data:
+  foo: bar

util/helm/cmd.go

@@ -221,6 +221,9 @@ func (c *Cmd) template(chartPath string, opts *TemplateOpts) (string, error) {
 	for _, v := range opts.APIVersions {
 		args = append(args, "--api-versions", v)
 	}
+	if c.HelmVer.additionalTemplateArgs != nil {
+		args = append(args, c.HelmVer.additionalTemplateArgs...)
+	}
 
 	return c.run(args...)
 }

util/helm/helmver.go

@@ -29,6 +29,7 @@ var (
 		pullCommand:             "pull",
 		initSupported:           false,
 		getPostTemplateCallback: cleanupChartLockFile,
+		additionalTemplateArgs:  []string{"--include-crds"},
 	}
 )
 
@@ -82,4 +83,5 @@ type HelmVer struct {
 	pullCommand             string
 	kubeVersionSupported    bool
 	getPostTemplateCallback func(chartPath string) (func(), error)
+	additionalTemplateArgs  []string
 }