feat: option to disable writing k8s events

fix unit test
- application_test
- applicationset_test
- project_test
- appcontroller_tes
- audit_logger_test

Signed-off-by: Jack-R-lantern <tjdfkr2421@gmail.com>

controller/appcontroller_test.go

@@ -49,7 +49,7 @@ import (
 	"github.com/argoproj/argo-cd/v2/util/settings"
 )
 
-var testEnableEventLog map[string](bool) = argo.TestEnableEventLog()
+var testEnableEventLog []string = argo.TestEnableEvent()
 
 type namespacedResource struct {
 	v1alpha1.ResourceNode

server/application/application_test.go

@@ -306,7 +306,7 @@ func newTestAppServerWithEnforcerConfigure(f func(*rbac.Enforcer), t *testing.T,
 		settingsMgr,
 		projInformer,
 		[]string{},
-		argo.TestEnableEventLog(),
+		argo.TestEnableEvent(),
 	)
 	return server.(*Server)
 }
@@ -487,7 +487,7 @@ func newTestAppServerWithEnforcerConfigureWithBenchmark(f func(*rbac.Enforcer),
 		settingsMgr,
 		projInformer,
 		[]string{},
-		argo.TestEnableEventLog(),
+		argo.TestEnableEvent(),
 	)
 	return server.(*Server)
 }

server/applicationset/applicationset_test.go

@@ -152,7 +152,7 @@ func newTestAppSetServerWithEnforcerConfigure(f func(*rbac.Enforcer), namespace
 		testNamespace,
 		sync.NewKeyLock(),
 		[]string{testNamespace, "external-namespace"},
-		argo.TestEnableEventLog(),
+		argo.TestEnableEvent(),
 	)
 	return server.(*Server)
 }

server/project/project_test.go

@@ -37,7 +37,7 @@ import (
 
 const testNamespace = "default"
 
-var testEnableEventLog map[string](bool) = argo.TestEnableEventLog()
+var testEnableEventLog []string = argo.TestEnableEvent()
 
 func TestProjectServer(t *testing.T) {
 	kubeclientset := fake.NewSimpleClientset(&corev1.ConfigMap{

util/argo/audit_logger_test.go

@@ -14,6 +14,13 @@ import (
 	argoappv1 "github.com/argoproj/argo-cd/v2/pkg/apis/application/v1alpha1"
 )
 
+const (
+	_somecomponent = "somecomponent"
+	_test          = "test"
+)
+
+var testEnableEventLog []string = []string{_somecomponent, _test}
+
 // Helper to capture log entries generated by the logger and return it as string
 func captureLogEntries(run func()) string {
 	f := log.StandardLogger().Formatter
@@ -29,13 +36,13 @@ func captureLogEntries(run func()) string {
 }
 
 func TestNewAuditLogger(t *testing.T) {
-	logger := NewAuditLogger("default", fake.NewSimpleClientset(), "somecomponent", TestEnableEventLog())
+	logger := NewAuditLogger("default", fake.NewSimpleClientset(), _somecomponent, testEnableEventLog)
 	assert.NotNil(t, logger)
 }
 
 func TestLogAppProjEvent(t *testing.T) {
 
-	logger := NewAuditLogger("default", fake.NewSimpleClientset(), "somecomponent", TestEnableEventLog())
+	logger := NewAuditLogger("default", fake.NewSimpleClientset(), _somecomponent, testEnableEventLog)
 	assert.NotNil(t, logger)
 
 	proj := argoappv1.AppProject{
@@ -51,7 +58,7 @@ func TestLogAppProjEvent(t *testing.T) {
 	}
 
 	ei := EventInfo{
-		Reason: "test",
+		Reason: _test,
 		Type:   "info",
 	}
 
@@ -64,10 +71,19 @@ func TestLogAppProjEvent(t *testing.T) {
 	assert.Contains(t, output, "reason=test")
 	assert.Contains(t, output, "type=info")
 	assert.Contains(t, output, "msg=\"This is a test message\"")
+
+	ei.Reason = "Unknown"
+
+	// If K8s Event Disable Log
+	output = captureLogEntries(func() {
+		logger.LogAppProjEvent(&proj, ei, "This is a test message", "")
+	})
+
+	assert.Empty(t, output)
 }
 
 func TestLogAppEvent(t *testing.T) {
-	logger := NewAuditLogger("default", fake.NewSimpleClientset(), "somecomponent", TestEnableEventLog())
+	logger := NewAuditLogger("default", fake.NewSimpleClientset(), _somecomponent, testEnableEventLog)
 	assert.NotNil(t, logger)
 
 	app := argoappv1.Application{
@@ -86,7 +102,7 @@ func TestLogAppEvent(t *testing.T) {
 	}
 
 	ei := EventInfo{
-		Reason: "test",
+		Reason: _test,
 		Type:   "info",
 	}
 
@@ -102,10 +118,18 @@ func TestLogAppEvent(t *testing.T) {
 	assert.Contains(t, output, "type=info")
 	assert.Contains(t, output, "msg=\"This is a test message\"")
 
+	ei.Reason = "Unknown"
+
+	// If K8s Event Disable Log
+	output = captureLogEntries(func() {
+		logger.LogAppEvent(&app, ei, "This is a test message", "")
+	})
+
+	assert.Empty(t, output)
 }
 
 func TestLogResourceEvent(t *testing.T) {
-	logger := NewAuditLogger("default", fake.NewSimpleClientset(), "somecomponent", TestEnableEventLog())
+	logger := NewAuditLogger("default", fake.NewSimpleClientset(), _somecomponent, testEnableEventLog)
 	assert.NotNil(t, logger)
 
 	res := argoappv1.ResourceNode{
@@ -120,7 +144,7 @@ func TestLogResourceEvent(t *testing.T) {
 	}
 
 	ei := EventInfo{
-		Reason: "test",
+		Reason: _test,
 		Type:   "info",
 	}
 
@@ -133,4 +157,13 @@ func TestLogResourceEvent(t *testing.T) {
 	assert.Contains(t, output, "reason=test")
 	assert.Contains(t, output, "type=info")
 	assert.Contains(t, output, "msg=\"This is a test message\"")
+
+	ei.Reason = "Unknown"
+
+	// If K8s Event Disable Log
+	output = captureLogEntries(func() {
+		logger.LogResourceEvent(&res, ei, "This is a test message", "")
+	})
+
+	assert.Empty(t, output)
 }