Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider): ensure ServerName and PortForwardNamespace are set on ClientOptions when port forwarding #378

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix(provider): ensure ServerName and PortForwardNamespace are set on ClientOptions when port forwarding #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/provider/model_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,11 @@ func (p ArgoCDProviderConfig) setPortForwardingOpts(ctx context.Context, opts *a
}

opts.ServerAddr = "localhost" // will be overwritten by ArgoCD module when we initialize the API client but needs to be set here to ensure we
opts.ServerName = "argocd-server"

if opts.PortForwardNamespace == "" {
opts.PortForwardNamespace = "argocd"
}

if p.Kubernetes == nil {
break
Expand Down
Loading