Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for dirApp #63

Merged
merged 19 commits into from
May 25, 2021
Merged

support for dirApp #63

merged 19 commits into from
May 25, 2021

Conversation

noam-codefresh
Copy link
Collaborator

@noam-codefresh noam-codefresh commented May 23, 2021

remaining work:

  • implement inferAppType
  • ensure/fix app delete implementation
  • fix current tests
  • add new tests

@noam-codefresh noam-codefresh self-assigned this May 23, 2021
@noam-codefresh noam-codefresh linked an issue May 23, 2021 that may be closed by this pull request
cmd/commands/project.go Outdated Show resolved Hide resolved
pkg/application/application.go Outdated Show resolved Hide resolved
pkg/application/application.go Show resolved Hide resolved
pkg/application/application.go Outdated Show resolved Hide resolved
pkg/application/application.go Outdated Show resolved Hide resolved
pkg/application/application.go Outdated Show resolved Hide resolved
pkg/fs/fs.go Outdated Show resolved Hide resolved
pkg/fs/fs.go Outdated Show resolved Hide resolved
pkg/store/store.go Outdated Show resolved Hide resolved
pkg/util/repospec.go Show resolved Hide resolved
@roi-codefresh roi-codefresh marked this pull request as ready for review May 24, 2021 07:11
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #63 (8754d28) into main (31d3833) will increase coverage by 1.77%.
The diff coverage is 69.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   48.27%   50.05%   +1.77%     
==========================================
  Files          11       13       +2     
  Lines        1707     2000     +293     
==========================================
+ Hits          824     1001     +177     
- Misses        811      928     +117     
+ Partials       72       71       -1     
Impacted Files Coverage Δ
cmd/commands/common.go 69.56% <ø> (ø)
pkg/application/application.go 48.12% <49.73%> (+5.16%) ⬆️
cmd/commands/app.go 36.19% <74.50%> (+6.13%) ⬆️
cmd/commands/repo.go 55.31% <75.00%> (ø)
pkg/util/repospec.go 88.07% <88.07%> (ø)
cmd/commands/project.go 53.73% <91.66%> (-1.86%) ⬇️
pkg/fs/fs.go 95.00% <92.50%> (-5.00%) ⬇️
pkg/git/repository.go 66.19% <100.00%> (-0.24%) ⬇️
pkg/util/util.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31d3833...8754d28. Read the comment docs.

@noam-codefresh noam-codefresh merged commit 7038573 into argoproj-labs:main May 25, 2021
@noam-codefresh noam-codefresh deleted the CR-4228 branch May 25, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support creating a "Directory" Argo-CD application
3 participants