Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end_with_user and include_system_prompt flags to Magpie tasks and handle Nones. #784

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

gabrielmbmb
Copy link
Member

@gabrielmbmb gabrielmbmb commented Jul 16, 2024

Description

This PR updates MagpieBase class to:

  • add a new attribute end_with_user that allows ending the conversation generated by Magpie tasks with a user message.
  • add a new attribute include_system_prompt which can be used to include or not the used system prompt in the generated conversation
  • updates the code to handle None from the LLM.generate method when generating a multi-turn conversation

@gabrielmbmb gabrielmbmb added the enhancement New feature or request label Jul 16, 2024
@gabrielmbmb gabrielmbmb added this to the 1.3.0 milestone Jul 16, 2024
@gabrielmbmb gabrielmbmb requested a review from plaguss July 16, 2024 12:07
@gabrielmbmb gabrielmbmb self-assigned this Jul 16, 2024
Copy link

Documentation for this PR has been built. You can view it at: https://distilabel.argilla.io/pr-784/

Copy link

codspeed-hq bot commented Jul 16, 2024

CodSpeed Performance Report

Merging #784 will not alter performance

Comparing magpie-end-with-flag (01a4bad) with develop (b22a494)

Summary

✅ 1 untouched benchmarks

@gabrielmbmb gabrielmbmb changed the title Add end_with_user flag to Magpie tasks Add end_with_user and include_system_prompt flags to Magpie tasks and handle Nones. Jul 19, 2024
@gabrielmbmb gabrielmbmb merged commit 0ef3f70 into develop Jul 19, 2024
7 checks passed
@gabrielmbmb gabrielmbmb deleted the magpie-end-with-flag branch July 19, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants