Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for distiset.save_to_disk kwargs #745

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

fpreiss
Copy link
Contributor

@fpreiss fpreiss commented Jun 20, 2024

The keyword argument for the path in Distiset.save_to_disk should be documented as distiset_path instead of dataset_path.

@plaguss plaguss self-requested a review June 21, 2024 07:12
@plaguss plaguss added documentation Improvements or additions to documentation example labels Jun 21, 2024
Copy link
Contributor

@plaguss plaguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch @fpreiss! 😃

Copy link

codspeed-hq bot commented Jun 21, 2024

CodSpeed Performance Report

Merging #745 will not alter performance

Comparing fpreiss:main (9065675) with main (3910aca)

Summary

✅ 1 untouched benchmarks

@plaguss plaguss merged commit 473408a into argilla-io:main Jun 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation example
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants