Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace multiprocessing with multiprocess #171

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

gabrielmbmb
Copy link
Member

Description

The ProcessLLM was not working in IPython/Notebooks because multiprocessing requires the __main__ module to be importable by the child process. In order to avoid this issue, multiprocessing has been replaced with multiprocess, a fork of multiprocessing that uses dill to overcome this issue.

multiprocess was already required by datasets dependency.

@gabrielmbmb gabrielmbmb added this to the 0.2.0 milestone Dec 19, 2023
@gabrielmbmb gabrielmbmb self-assigned this Dec 19, 2023
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/pipeline-llamacpp-and-openai-process.py Outdated Show resolved Hide resolved
examples/pipeline-llamacpp-and-openai-process.py Outdated Show resolved Hide resolved
examples/pipeline-llamacpp-and-openai-process.py Outdated Show resolved Hide resolved
@gabrielmbmb gabrielmbmb force-pushed the add_multiprocess_dependency branch from d7398d7 to e3db5e8 Compare December 19, 2023 16:06
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
@alvarobartt alvarobartt merged commit 9a318e4 into main Dec 19, 2023
4 checks passed
@alvarobartt alvarobartt deleted the add_multiprocess_dependency branch December 19, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants