Fix shuffle_before_labelling and progress bar in Pipeline.generate
#170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarobartt
changed the title
shuffle_before_labelling and Pipeline.generateshuffle_before_labelling and progress bar in Pipeline.generate
gabrielmbmb
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves a bug that was introduced as of #166 since the
shuffle_before_labellingarg was included, but it was not propagated fromPipeline.generateand as no kwargs were used in_get_batch_generationsso thegeneration_progress_funcwas being interpreted as theshuffle_before_labellingarg and the progress bar was also broken due to that.