Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] argilla-server: remove deprecated records endpoint #5206

Conversation

frascuchon
Copy link
Member

Description

This PR removes deprecated endpoints working with records to avoid creating records with a proper record status computation. The affected endpoints are:

POST /api/v1/datasets/:dataset_id/records
PATCH /api/v1/datasets/:dataset_id/records

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon marked this pull request as ready for review July 11, 2024 09:52
@frascuchon frascuchon requested a review from jfcalvo July 11, 2024 09:52
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.25%. Comparing base (b15de8f) to head (6271865).

Additional details and impacted files
@@                               Coverage Diff                                @@
##           feat/add-dataset-automatic-task-distribution    #5206      +/-   ##
================================================================================
- Coverage                                         92.01%   91.25%   -0.76%     
================================================================================
  Files                                               137      137              
  Lines                                              5901     5823      -78     
================================================================================
- Hits                                               5430     5314     -116     
- Misses                                              471      509      +38     
Flag Coverage Δ
argilla-server 91.25% <100.00%> (-0.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

argilla-server/CHANGELOG.md Show resolved Hide resolved
@frascuchon frascuchon merged commit 85e847f into feat/add-dataset-automatic-task-distribution Jul 12, 2024
6 checks passed
@frascuchon frascuchon deleted the refactor/remove-deprecated-records-endpoint branch July 12, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants