Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add status column to records table #5059

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Jun 19, 2024

Description

This PR include changes to add a new status column to records table with the following details:

  • Possible values for this status column are pending and completed.
  • This new column will be non-nullable.
  • It will have a database index so it will be faster to recover records with one specific status value.
  • By default the status column will have the pending value. (Showing that the record is still pending of being annotated).
  • Existent old records will be migrated in the following way:
    • Records with a least one response with submitted status will be updated from pending to completed.

Closes #5058

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Manually test migration with SQLite.
  • Manually test migration with PostgreSQL.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon June 19, 2024 10:06
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.98%. Comparing base (d5b762c) to head (a5826cb).
Report is 89 commits behind head on feat/create-datasets-with-distribution.

Current head a5826cb differs from pull request most recent head 3ab044e

Please upload reports for the commit 3ab044e to get more accurate results.

Additional details and impacted files
@@                             Coverage Diff                             @@
##           feat/create-datasets-with-distribution    #5059       +/-   ##
===========================================================================
+ Coverage                                   61.16%   91.98%   +30.82%     
===========================================================================
  Files                                         328      136      -192     
  Lines                                       17683     5855    -11828     
===========================================================================
- Hits                                        10815     5386     -5429     
+ Misses                                       6868      469     -6399     
Flag Coverage Δ
argilla ?
argilla-server 91.98% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jfcalvo and others added 7 commits June 28, 2024 14:22
…5028)

# Description

This PR add changes to support update dataset distribution settings.
Allowing for example to update `min_submitted` attribute when `overlap`
distribution strategy is in use.

Closes #5010 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [ ] Documentation update

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [x] Adding new tests.

**Checklist**

- [ ] I added relevant documentation
- [ ] follows the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: Paco Aranda <francis@argilla.io>
Base automatically changed from feat/update-datasets-distribution to feat/create-datasets-with-distribution July 1, 2024 10:22
Base automatically changed from feat/create-datasets-with-distribution to feat/add-dataset-automatic-task-distribution July 1, 2024 10:31
@jfcalvo jfcalvo closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant