Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken search url #4633

Closed
wants to merge 2 commits into from
Closed

fix: broken search url #4633

wants to merge 2 commits into from

Conversation

katsuya
Copy link

@katsuya katsuya commented Mar 7, 2024

Description

This PR fixes an issue where an invalid URL was generated due to passing an enum itself instead of its value to a template. Below are the URLs before and after the change:

  • Before: /api/datasets/dataset__07_03_2024_15_06_50/TaskType.text_classification:search
  • After: /api/datasets/dataset__07_03_2024_15_06_50/TextClassification:search

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints language: python Pull requests or issues that update Python code severity: minor Indicates that the issue isn't urgent or blocking team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior labels Mar 7, 2024
@katsuya
Copy link
Author

katsuya commented Mar 7, 2024

It seems to be due to changes in the Enum specification in 3.11. I found that it works correctly in 3.10.

@frascuchon
Copy link
Member

Thanks for contributing, @katsuya

We may have other places where this kind of error arises. I would love to know how did you find it.

@katsuya
Copy link
Author

katsuya commented Apr 16, 2024

@frascuchon I discovered this issue while running autoprompt. Specifically, an error occurs at https://github.com/Eladlev/AutoPrompt/blob/7f373f219aa360cd2de38c6aa700c1dff282d7de/estimator/estimator_argilla.py#L106-L111. This section of the code checks if all records have been annotated.

@katsuya
Copy link
Author

katsuya commented Apr 16, 2024

I checked the source code to see if this issue still occurs, and it seems to have been fixed in #4672. Are you still experiencing bugs even after applying this patch?

@frascuchon
Copy link
Member

Thanks for all this info @katsuya.

@frascuchon frascuchon self-requested a review April 17, 2024 08:05
@frascuchon
Copy link
Member

frascuchon commented Apr 17, 2024

I checked the source code to see if this issue still occurs, and it seems to have been fixed in #4672. Are you still experiencing bugs even after applying this patch?

Not really, I refreshed your PR with the latest changes from develop branch and it looks is already fixed. I will close this PR, since same changes are already in develop.

@frascuchon frascuchon closed this Apr 17, 2024
@frascuchon frascuchon reopened this Apr 17, 2024
@frascuchon frascuchon closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints language: python Pull requests or issues that update Python code severity: minor Indicates that the issue isn't urgent or blocking size:XS This PR changes 0-9 lines, ignoring generated files. team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants