Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: validate Dappland banner #1984

Merged
merged 2 commits into from
Mar 31, 2023
Merged

tests: validate Dappland banner #1984

merged 2 commits into from
Mar 31, 2023

Conversation

canlopes
Copy link
Contributor

@canlopes canlopes commented Mar 30, 2023

Issue / feature description

Added tests:

  • dapps banner should be visible after login
  • dapps banner should not be visible after dismissed
  • dapps banner shoud be visible after account recovery

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

Please keep your pull request as small as possible. If you need to make multiple changes, please create separate pull requests for each change. Create a draft pull request if you need early feedback. This will mark the pull request as a work in progress and prevent it from being reviewed or merged until you are ready.

Please move drafts to the ready for review (regular PR) when you are ready to start the review process and other developers will pick it up from there.

@github-actions
Copy link

Builds for local testing

@github-actions
Copy link

Builds for local testing

1 similar comment
@github-actions
Copy link

Builds for local testing

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
1.9% 1.9% Duplication

@canlopes canlopes merged commit 409678a into develop Mar 31, 2023
@canlopes canlopes deleted the tests/dappland-banner branch March 31, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants