Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLO-892 hotfix: ensure sparse account object #1961

Merged
merged 1 commit into from
Mar 27, 2023
Merged

BLO-892 hotfix: ensure sparse account object #1961

merged 1 commit into from
Mar 27, 2023

Conversation

simonheys
Copy link
Collaborator

@simonheys simonheys commented Mar 27, 2023 •
edited
Loading

Issue / feature description

Users unable to switch network on FireFox (due to DataCloneError on FF)

Changes

  • coerce stored account to the expected sparse object

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@github-actions
Copy link

Builds for local testing

@simonheys simonheys changed the title fix: ensure sparse account object BLO-892 fix: ensure sparse account object Mar 27, 2023
@simonheys simonheys marked this pull request as ready for review March 27, 2023 11:54
@simonheys simonheys changed the base branch from develop to main March 27, 2023 11:55
@simonheys simonheys added the RC label Mar 27, 2023
@simonheys simonheys changed the title BLO-892 fix: ensure sparse account object BLO-892 hotfix: ensure sparse account object Mar 27, 2023
@simonheys simonheys marked this pull request as draft March 27, 2023 11:56
@simonheys simonheys marked this pull request as ready for review March 27, 2023 11:57
@github-actions
Copy link

Builds for local testing

@github-actions
Copy link

Builds for local testing

@simonheys simonheys changed the base branch from main to fix/pipeline March 27, 2023 13:45
Base automatically changed from fix/pipeline to main March 27, 2023 13:50
@github-actions
Copy link

Builds for local testing

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
2.1% 2.1% Duplication

@simonheys simonheys merged commit 577723e into main Mar 27, 2023
@simonheys simonheys deleted the fix/BLO-892-ff branch March 27, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegodelrieu diegodelrieu diegodelrieu approved these changes

@bluecco bluecco bluecco approved these changes

Assignees
No one assigned
Labels
RC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonheys @bluecco @diegodelrieu