Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLO-922 fix: 2fa check #1936

Merged
merged 1 commit into from
Mar 23, 2023
Merged

BLO-922 fix: 2fa check #1936

merged 1 commit into from
Mar 23, 2023

Conversation

simonheys
Copy link
Collaborator

@simonheys simonheys commented Mar 22, 2023 •
edited
Loading

Issue / feature description

2fa should check for both undeployed + upgradable accounts when activating

Changes

  • refactor check
  • remove unused hook

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@simonheys simonheys changed the base branch from develop to main March 22, 2023 11:06
@simonheys simonheys force-pushed the hotfix/BLO-922-2fa-undeployed branch from 45a11da to 01a5066 Compare March 22, 2023 11:09
@simonheys simonheys force-pushed the hotfix/BLO-922-2fa-undeployed branch from 01a5066 to 47d0699 Compare March 22, 2023 11:13
@github-actions
Copy link

Builds for local testing

@github-actions
Copy link

Builds for local testing

@github-actions
Copy link

Builds for local testing

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
2.1% 2.1% Duplication

@simonheys simonheys marked this pull request as ready for review March 22, 2023 15:42
@simonheys simonheys merged commit 6ecb5d6 into main Mar 23, 2023
@simonheys simonheys deleted the hotfix/BLO-922-2fa-undeployed branch March 23, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegodelrieu diegodelrieu diegodelrieu approved these changes

@janek26 janek26 janek26 approved these changes

Assignees
No one assigned
Labels
2fa RC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonheys @janek26 @diegodelrieu