Hotfix/tx sim #1930
Merged
Hotfix/tx sim #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkelawala
commented
Mar 21, 2023
Comment on lines
-17
to
-51
| export const handleTransactionMessage: HandleMessage< | ||
| TransactionMessage | ||
| > = async ({ msg, background: { wallet, actionQueue }, respond: respond }) => { | ||
| switch (msg.type) { | ||
| case "EXECUTE_TRANSACTION": { | ||
| const { meta } = await actionQueue.push({ | ||
| type: "TRANSACTION", | ||
| payload: msg.data, | ||
| }) | ||
| return respond({ | ||
| type: "EXECUTE_TRANSACTION_RES", | ||
| data: { actionHash: meta.hash }, | ||
| }) | ||
| } | ||
|
|
||
| case "ESTIMATE_TRANSACTION_FEE": { | ||
| const selectedAccount = await wallet.getSelectedAccount() | ||
| const starknetAccount = await wallet.getSelectedStarknetAccount() | ||
| const transactions = msg.data | ||
|
|
||
| if (!selectedAccount) { | ||
| throw Error("no accounts") | ||
| export const handleTransactionMessage: HandleMessage<TransactionMessage> = | ||
| async ({ msg, background: { wallet, actionQueue }, respond: respond }) => { | ||
| switch (msg.type) { | ||
| case "EXECUTE_TRANSACTION": { | ||
| const { meta } = await actionQueue.push({ | ||
| type: "TRANSACTION", | ||
| payload: msg.data, | ||
| }) | ||
| return respond({ | ||
| type: "EXECUTE_TRANSACTION_RES", | ||
| data: { actionHash: meta.hash }, | ||
| }) | ||
| } | ||
| try { | ||
| let txFee = "0", | ||
| maxTxFee = "0", | ||
| accountDeploymentFee: string | undefined, | ||
| maxADFee: string | undefined | ||
|
|
||
| if ( | ||
| selectedAccount.needsDeploy && | ||
| !(await isAccountDeployed( | ||
| selectedAccount, | ||
| starknetAccount.getClassAt, | ||
| )) |
There was a problem hiding this comment.
Not sure why but the linter is auto-formatting code on commit. There hasn't been so many changes
dhruvkelawala
commented
Mar 21, 2023
| signature, | ||
| nonce, | ||
| version, | ||
| const nonce = await starknetAccount.getNonce() |
There was a problem hiding this comment.
This is the main change in this file
|
Kudos, SonarCloud Quality Gate passed! |
janek26
approved these changes
Mar 21, 2023
simonheys
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
Add New Transaction Simulation Spinner and fix nonce issue
Checklist