Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speedup e2e #1912

Merged
merged 1 commit into from
Mar 15, 2023
Merged

feat: speedup e2e #1912

merged 1 commit into from
Mar 15, 2023

Conversation

dhruvkelawala
Copy link
Contributor

Issue / feature description

This PR speeds up e2e-tests by computing class hash for Proxy and Account Contracts and checking if it's already declared. This is way faster than declaring contracts everytime.

Changes

  • Compute and check if class exists before declaring on Localhost

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@github-actions
Copy link

Builds for local testing

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
2.2% 2.2% Duplication

@canlopes canlopes requested review from janek26 and simonheys March 14, 2023 20:40
@canlopes canlopes merged commit 35e80cb into develop Mar 15, 2023
@canlopes canlopes deleted the chore/e2e-speedup branch March 15, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants