Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLO-898 fix: token list #1911

Merged
merged 1 commit into from
Mar 14, 2023
Merged

BLO-898 fix: token list #1911

merged 1 commit into from
Mar 14, 2023

Conversation

simonheys
Copy link
Collaborator

@simonheys simonheys commented Mar 14, 2023 •
edited
Loading

Issue / feature description

Token list overflow with ethers 6 and large values

Changes

  • use common ethers package
  • ignore parse errors

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@simonheys simonheys force-pushed the hotfix/BLO-898-token-list branch 2 times, most recently from 54e09a1 to 9cb9b38 Compare March 14, 2023 15:55
@simonheys simonheys marked this pull request as ready for review March 14, 2023 15:55
@simonheys simonheys requested a review from diegodelrieu March 14, 2023 15:56
@simonheys simonheys added the RC label Mar 14, 2023
@simonheys simonheys force-pushed the hotfix/BLO-898-token-list branch from 9cb9b38 to aebcefe Compare March 14, 2023 16:10
diegodelrieu
diegodelrieu approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@diegodelrieu diegodelrieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this specific to ethers 6 ?

@simonheys
Copy link
Collaborator Author

is this specific to ethers 6 ?

Seemed to be - it was overflowing with some crazy big numbers. Didn't seem worth fixing in ethers 6 - we still have work to do in main packages to migrate over to it.

@simonheys simonheys merged commit 73a6fb9 into main Mar 14, 2023
@simonheys simonheys deleted the hotfix/BLO-898-token-list branch March 14, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvkelawala dhruvkelawala dhruvkelawala approved these changes

@diegodelrieu diegodelrieu diegodelrieu approved these changes

Assignees
No one assigned
Labels
RC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonheys @diegodelrieu @dhruvkelawala