Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ci flags for 2fa #1907

Merged
merged 1 commit into from
Mar 14, 2023
Merged

chore: ci flags for 2fa #1907

merged 1 commit into from
Mar 14, 2023

Conversation

simonheys
Copy link
Collaborator

@simonheys simonheys commented Mar 14, 2023 •
edited
Loading

Issue / feature description

Enable 2fa in CI builds

Changes

  • add flags to enable 2fa on mainnet in CI

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@simonheys simonheys marked this pull request as ready for review March 14, 2023 09:47
@simonheys simonheys added the 2fa label Mar 14, 2023
@github-actions
Copy link

Builds for local testing

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
2.5% 2.5% Duplication

@simonheys simonheys merged commit b6239a1 into develop Mar 14, 2023
@simonheys simonheys deleted the feature/2fa-flags branch March 14, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvkelawala dhruvkelawala dhruvkelawala approved these changes

@diegodelrieu diegodelrieu diegodelrieu approved these changes

@bluecco bluecco Awaiting requested review from bluecco

Assignees
No one assigned
Labels
2fa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonheys @diegodelrieu @dhruvkelawala