BLO-875 feat: 2fa analytics #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonheys
force-pushed
the
feature/BLO-875-2fa-analytics
branch
from
1215b71 to
51c6fec
Compare
simonheys
force-pushed
the
feature/BLO-875-2fa-analytics
branch
from
2a773ca to
6ea1b3a
Compare
simonheys
force-pushed
the
feature/BLO-875-2fa-analytics
branch
from
ffe5a82 to
d65ea9f
Compare
bluecco
approved these changes
Mar 14, 2023
| @@ -44,6 +46,66 @@ export const usePageTracking = <T extends keyof Pages>( | |||
| }, [name, rest[0]]) // as React in strict mode renders every component twice, this page will be tracked 2x in development. This is not the case in production. | |||
| } | |||
|
|
|||
| export const useTimeSpentWithSuccessTracking = <T extends keyof Events>( | |||
There was a problem hiding this comment.
very neat, would be worth adding a few tests to
diegodelrieu
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
Adds analytics to 2fa
Changes
Checklist