Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLO-879 feat: use ui package for dapp screen #1901

Merged
merged 1 commit into from
Mar 14, 2023
Merged

BLO-879 feat: use ui package for dapp screen #1901

merged 1 commit into from
Mar 14, 2023

Conversation

simonheys
Copy link
Collaborator

Issue / feature description

Some long dapp names not displaying correcty

Changes

  • use ui package for dapp list
  • truncate long names
  • add storybook

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally
    `

Screenshot 2023-03-10 at 11 05 25

Screenshot 2023-03-10 at 11 10 32

Before
Screenshot 2023-03-10 at 10 59 12

simonheys
simonheys commented Mar 10, 2023
View reviewed changes
packages/extension/src/ui/features/accounts/upgrade.service.ts

// return { needsUpgrade, needsUpgradeError, needsUpgradeValidating }
return { needsUpgrade, needsUpgradeError, needsUpgradeValidating }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverses unintentional commit

@github-actions
Copy link

Builds for local testing

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 10, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.0% 2.0% Duplication

@simonheys simonheys requested a review from bluecco March 13, 2023 11:42
@simonheys simonheys merged commit a2200ec into develop Mar 14, 2023
@simonheys simonheys deleted the fix/BLO-879-dapp-list branch March 14, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegodelrieu diegodelrieu diegodelrieu approved these changes

@bluecco bluecco bluecco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simonheys @bluecco @diegodelrieu