Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fallback icon for missing nft #1899

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Conversation

diegodelrieu
Copy link
Contributor

Issue / feature description

Adding a fallback icon where it's missing

@github-actions
Copy link

Builds for local testing

@github-actions
Copy link

Builds for local testing

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.1% 2.1% Duplication

Comment on lines 79 to 80
w="64px"
h="64px"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can please use spacer values instead of px?

@diegodelrieu diegodelrieu merged commit 3994b37 into develop Mar 10, 2023
@diegodelrieu diegodelrieu deleted the fix/add-nft-fallback-icon branch March 10, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants