Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/swap prices #1885

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Fix/swap prices #1885

merged 3 commits into from
Mar 9, 2023

Conversation

dhruvkelawala
Copy link
Contributor

@dhruvkelawala dhruvkelawala commented Mar 8, 2023 •
edited
Loading

Issue / feature description

Fixes the Currency Value price shown in "Pay With" Swap Modal

Checklist

  • Rebased to the last commit of the target branch (or merged)
  • Code self-reviewed
  • Code self-tested
  • Tests updated (if needed)
  • All tests are passing locally

@dhruvkelawala dhruvkelawala marked this pull request as ready for review March 8, 2023 13:28
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Builds for local testing

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Builds for local testing

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
2.2% 2.2% Duplication

@simonheys simonheys merged commit 983576d into develop Mar 9, 2023
@simonheys simonheys deleted the fix/swap-prices branch March 9, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluecco bluecco bluecco approved these changes

@simonheys simonheys simonheys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhruvkelawala @simonheys @bluecco