Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BLO-769] Make wait time dynamic to speed up QA and testing work #1844

Merged
merged 5 commits into from
Mar 7, 2023

Conversation

diegodelrieu
Copy link
Contributor

Issue / feature description

` Make wait time dynamic to speed up QA and testing work

@github-actions
Copy link

Builds for local testing

Copy link
Collaborator

@janek26 janek26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this fix the issue @canlopes is having?
This would require him to always have an "QA" build with an custom env var, not applicable to RCs

I think you should return the inflight transactions from transactionTracker.update instead of just a flag which indicates if there are inflight transactions.
Once done, we can calculate that flag in the method plus additionally check if there are any transactions targeting network with id localhost. If so, then we can acceleratepolling (aka decrease waiting time between runs)

@diegodelrieu
Copy link
Contributor Author

does this fix the issue @canlopes is having? This would require him to always have an "QA" build with an custom env var, not applicable to RCs

I think you should return the inflight transactions from transactionTracker.update instead of just a flag which indicates if there are inflight transactions. Once done, we can calculate that flag in the method plus additionally check if there are any transactions targeting network with id localhost. If so, then we can acceleratepolling (aka decrease waiting time between runs)

Thanks ! I think this is better now ?

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Builds for local testing

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Builds for local testing

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Builds for local testing

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
2.2% 2.2% Duplication

@diegodelrieu diegodelrieu merged commit a09f3d6 into develop Mar 7, 2023
@diegodelrieu diegodelrieu deleted the BLO-769 branch March 7, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants