BLO-838 chore: use endpoint to determine token expiry #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| await jwtFetcher(`${ARGENT_API_BASE_URL}/account`) | ||
| return false | ||
| } catch (error) { | ||
| IS_DEV && console.warn(coerceErrorToString(error)) |
There was a problem hiding this comment.
I've seen this pattern elsewhere but why collect logs only in dev mode ?
There was a problem hiding this comment.
The logs can be informative if the service might return unexpected errors as it can here. This has already been useful for debugging with be. Dev only so they don't end up leaking unnecessarily into a prod build.
diegodelrieu
approved these changes
Mar 6, 2023
bluecco
approved these changes
Mar 7, 2023
simonheys
force-pushed
the
feat/BLO-838-2fa-expiry
branch
from
21f7f4a to
874ca5b
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
Can use endpoint to check token expiry (excluding for removal)
Changes
Checklist