Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test PG counters is accurate when using create_only_config_db_buffers… #1

Closed
wants to merge 1 commit into from

Conversation

arfeigin
Copy link
Owner

@arfeigin arfeigin commented Mar 6, 2024

… optimization

Description of PR

This test is checking that PG counters inside snmp docker are accurate when using create_only_config_db_counters optimization.

Summary:
Fixes sonic-net/sonic-buildimage#17448 and is related to the fix, available in sonic-net/sonic-snmpagent#303

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

To enhance the bug fix mentioned above solving an issue with PG counters optimization.

How did you do it?

  - Set "create_only_config_db_buffers" to true in config db, to create only relevant PG counters.
  - Remove one of the buffer queues, Ethernet0|3-4 is arbitrary chosen.
  - Using snmpwalk compare number of PG counters on Ethernet0, assuming there will be 8 less after
    removing the buffer. (Assuming unicast only, 4 pg counters for each lane in this case).

How did you verify/test it?

Run the test multiple times on various setups.

Any platform specific information?

Test assumes unicast only

Supported testbed topology if it's a new test case?

Documentation

@arfeigin arfeigin closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The feature "polling only configured ports buffer queue" will break SNMP
1 participant