Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: support testing on Windows #214

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

jason-ha
Copy link
Contributor

@jason-ha jason-ha commented Sep 20, 2024

  • package.json_s: use compatible quoting
  • use posix paths in createTestPackage
  • convert \r\n to \n before comparing strings
    • correct naming of snapshot strings; deduplicate write logic
  • resolve file relative paths with fileURLToPath
  • add Windows to CI test matrix

- package.json_s: use compatible quoting
- use posix paths in createTestPackage
- convert `\r\n` to `\n` before comparing strings
  - correct naming of snapshot strings; deduplicate write logic
- resolve file relative paths with `fileURLToPath`
Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: ede64c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you so much! Would you be up for adding a Windows runner to the CI workflow before merging?

@jason-ha
Copy link
Contributor Author

This is great, thank you so much! Would you be up for adding a Windows runner to the CI workflow before merging?

I don't know what that is but I Will take a look. Can add another PR after if I don't figure it out straightaway.

@andrewbranch
Copy link
Collaborator

This example shows something like what I have in mind: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#using-a-matrix-strategy

@andrewbranch andrewbranch merged commit fcb4268 into arethetypeswrong:main Sep 22, 2024
2 checks passed
@jason-ha jason-ha deleted the test-on-windows branch September 24, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants