Add CircleCI build #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanlong
force-pushed
the
circleci
branch
8 times, most recently
from
6cb6cc6 to
12c10de
Compare
brendanlong
commented
Dec 21, 2017
| @@ -11,7 +11,7 @@ install: [jbuilder install] | |||
| remove: [jbuilder uninstall] | |||
|
|
|||
| depends: [ | |||
| "async" {= "v0.9.1"} | |||
There was a problem hiding this comment.
v0.9.1 doesn't exist.. oops.
kevinqiu
reviewed
Dec 21, 2017
| @@ -1,3 +1,5 @@ | |||
| [](https://circleci.com/gh/arenadotio/pgx) | |||
There was a problem hiding this comment.
Can remove the comment from line 16 now that this is added.
bradlangel
reviewed
Dec 21, 2017
| @@ -11,7 +11,7 @@ install: [jbuilder install] | |||
| remove: [jbuilder uninstall] | |||
|
|
|||
| depends: [ | |||
| "async" {= "v0.9.1"} | |||
There was a problem hiding this comment.
Is this change relevant to circle ci?
There was a problem hiding this comment.
This is required because we're using opam install --deps-only pgx_async, and v0.9.1 doesn't exist. I moved the change to a different commit with a description.
v0.9.1 doesn't exist. We didn't run into this internally since we don't use the .opam files in our repo.
brendanlong
force-pushed
the
circleci
branch
from
12c10de to
952b782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.