Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve message for authentication errors #105

Merged
merged 3 commits into from
Feb 25, 2021
Merged

improve message for authentication errors #105

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
939ddae
improve message for authentication errors
Feb 24, 2021
71a051a
use newer opam images for build
Feb 25, 2021
2917b46
add upper bound on conduit
Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pgx/src/pgx.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,8 @@ module Make (Thread : Io) = struct
loop (Some (Message_out.Password password))
| Message_in.AuthenticationSCMCredential ->
fail_msg "Pgx: SCM Credential authentication not supported"
| Message_in.ErrorResponse err -> pg_error ~conn err
| Message_in.ErrorResponse err ->
raise (PostgreSQL_Error ("Failed to authenticate with postgres server", err))
| Message_in.NoticeResponse _ ->
(* XXX Do or print something here? *)
loop None
Expand Down