Set Pgx module to wrapped #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuragsoni
reviewed
Jun 23, 2020
| @@ -10,7 +10,6 @@ let () = Jbuild_plugin.V1.send @@ {| | |||
|
|
|||
| (library | |||
| (public_name pgx) | |||
| (wrapped false) | |||
There was a problem hiding this comment.
we should probably remove the wrapped from pgx_async as well. I think we currentl expose Pgx_async_test in the public api but that's really only needed for tests. We could perhaps use core_kernel's module that indicates something is supposed to be for test only?
There was a problem hiding this comment.
Yeah I was considering just dropping Pgx_async_test entirely or moving it somewhere else. It doesn't belong in the public API at all.
bradlangel
approved these changes
Jun 23, 2020
This makes us only expose the Pgx module at top-level. Most of this stuff was never intended to be used directly, so the only major change is that Pgx_value now _must_ be referenced as Pgx.Value. Fixes #101
brendanlong
added a commit
to brendanlong/opam-repository
that referenced
this pull request
May 12, 2021
…x_lwt_unix, pgx_lwt and pgx (2.0) CHANGES: ### Breaking changes * The Pgx module is now wrapped, which means `Pgx_aux`, `Types`, `Access`, etc. aren't added to the global scope. The main result of this is that `Pgx_value` now needs to be accessed as `Pgx.Value`. (arenadotio/pgx#103) * `Pgx_async.connect` and `with_conn` now have an additional optional `?ssl` argument (see below). ### Added * Pgx_async now supports TLS connections using Conduit_async. This is enabled by default and can be controlled with the new `?ssl` argument to `connect` and `with_conn`. (arenadotio/pgx#108) ### Fixed * Improved message for authentication errors. Previously these raised `Pgx_eof`, and now they raise `PostgreSQL_Error("Failed to authenticate with postgres server", additional details ...)`. (arenadotio/pgx#105) ### Changed * Support new Mirage-conduit timeout argument (arenadotio/pgx#95).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes us only expose the Pgx module at top-level.
Most of this stuff was never intended to be used directly, so the only
major change is that Pgx_value now must be referenced as Pgx.Value.
Fixes #101