Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow to lint TypeScript and JavaScript code #55

Merged
merged 2 commits into from
May 17, 2023

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Dec 14, 2022

On every push and pull request that affects relevant files, and periodically, run eslint on the repository's TypeScript and JavaScript files.

eslint is configured via the .eslintrc.yml file:
https://eslint.org/docs/user-guide/configuring/configuration-files

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Dec 14, 2022
@MatteoPologruto MatteoPologruto self-assigned this Dec 14, 2022
.eslintrc.cjs Outdated Show resolved Hide resolved
.eslintrc.yml Outdated Show resolved Hide resolved
Taskfile.yml Outdated Show resolved Hide resolved
@MatteoPologruto
Copy link
Contributor Author

MatteoPologruto commented Dec 21, 2022

I removed the commits that tried to fix the errors highlighted by eslint. Making the workflow's run introduced with this PR succeed will be handled separately.

On every push and pull request that affects relevant files, and periodically, run eslint on the repository's TypeScript
and JavaScript files.

eslint is configured via the .eslintrc.yml file:
https://eslint.org/docs/user-guide/configuring/configuration-files
@alessio-perugini alessio-perugini self-requested a review May 17, 2023 15:53
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary ignoring linting issues so we can tag a release before 18 May

@MatteoPologruto MatteoPologruto dismissed per1234’s stale review May 17, 2023 15:57

Dismissing this review for now so we can make a new release

@MatteoPologruto MatteoPologruto merged commit 5ccf14d into arduino:master May 17, 2023
@umbynos
Copy link

umbynos commented May 18, 2023

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants