Apply update of workflows from asset repo #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+176
to
+179
| err := d.serialPort.Close() | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I'm not sure why we were ignoring this error, but I'd ask @cmaglie if we want to report closing errors or not.
There was a problem hiding this comment.
As per the pluggable monitor protocol specification, the CLOSE command must always succeed (i.e. it must not return any error). The reason is that we cannot do much in case the serial port fails to close. I'd just ignore the error:
There was a problem hiding this comment.
Uhm... actually no, https://arduino.github.io/arduino-cli/0.35/pluggable-monitor-specification/#close-command I'm confused with the pluggable-discovery.
Disregard my previous comment, it's OK as you did @umbynos
There was a problem hiding this comment.
Fantastic, Put the green mark please 🙏
alessio-perugini
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several updates to the asset repo have been made, I've just ported them to this repo.
TODO:
AWS_ROLE_TO_ASSUMEAWS_ACCESS_KEY_IDAWS_SECRET_ACCESS_KEY