Generate v1 and v2 format test data artifacts #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A significant change was made to the nature of GitHub Actions workflow artifacts starting from the 2.x release of the `@actions/artifact` package, which was introduced in the 4.0.0 release of the "actions/upload-artifact" GitHub Actions action. It is necessary to provide integration test coverage for compatibility of the "arduino/report-size-deltas" action with the v2 format artifacts produced by actions/upload-artifact@v4. It is also important to continue to cover compatibility with the v1 format artifacts produced by actions/upload-artifact@v3, to support users who have not gotten around to updating that action dependency in their sketch compilation workflows (especially since the breaking change introduced by actions/upload-artifact@v4 will make it necessary to adjust the configuration of the workflow). The chosen approach is to configure the "Upload test sketches report artifact" workflow to use actions/upload-artifact@v3 when upload one of the test data artifacts and actions/upload-artifact@v4 when uploading the other. Even though the produced test data would not occur under real world usage, it is the cleanest way (the alternative being to create and maintain separate copies of the system implemented in the `report-target-pr` branch for each major version of the actions/upload-artifact action) to provide effective integration test coverage.
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A significant change was made to the nature of GitHub Actions workflow artifacts starting from the 2.x release of the
@actions/artifactpackage, which was introduced in the 4.0.0 release of the "actions/upload-artifact" GitHub Actions action.It is necessary to provide integration test coverage for compatibility of the "arduino/report-size-deltas" action with the v2 format artifacts produced by
actions/upload-artifact@v4. It is also important to continue to cover compatibility with the v1 format artifacts produced byactions/upload-artifact@v3, to support users who have not gotten around to updating that action dependency in their sketch compilation workflows (especially since the breaking change introduced by actions/upload-artifact@v4 will make it necessary to adjust the configuration of the workflow (per1234/.github#109)).The chosen approach is to configure the "Upload test sketches report artifact" workflow to use
actions/upload-artifact@v3when uploading one of the test data artifacts andactions/upload-artifact@v4when uploading the other. Even though the produced test data would not occur under real world usage, it is the cleanest way (the alternative being to create and maintain separate copies of the system implemented in thereport-target-prbranch for each major version of the actions/upload-artifact action) to provide effective integration test coverage.