Upload multiple test data artifacts to provide coverage for artifact name pattern feature #79
+751
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name pattern feature The action was originally designed for a use case where there will only be a single sketches reports workflow artifact. Due to a change in the "actions/upload-artifact" GitHub Actions action, it became necessary to add the capability for the "arduino/report-size-deltas" action to be able to consume reports from multiple artifacts. The "Upload test sketches report artifact" GitHub Actions workflow is hereby updated to produce multiple test data artifacts in order to allow the "Run integration tests" workflow to provide coverage for the new capability. As was previously the case, one of the artifacts uploaded by the workflow contains multiple sketches report files in order to provide test data necessary to continue providing coverage for the <=actions/upload-artifact@v3 single artifact system. Even though the produced test data (multiple artifacts, with multiple reports in a single artifact) would not occur under real world usage, it is the cleanest way (the alternative being to create and maintain separate copies of the system implemented in the `report-target-pr` branch for each use pattern) to provide effective integration test coverage.
per1234
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action was originally designed for a use case where there will only be a single sketches reports workflow artifact. Due to a change in the "actions/upload-artifact" GitHub Actions action, it became necessary to add the capability for the "arduino/report-size-deltas" action to be able to consume reports from multiple artifacts (#78).
The "Upload test sketches report artifact" GitHub Actions workflow is here updated to produce multiple test data artifacts in order to allow the "Run integration tests" workflow to provide coverage for the new capability.
As was previously the case, one of the artifacts uploaded by the workflow contains multiple sketches report files in order to provide test data necessary to continue providing coverage for the <=
actions/upload-artifact@v3single artifact system. Even though the produced test data (multiple artifacts, with multiple reports in a single artifact) would not occur under real world usage, it is the cleanest way (the alternative being to create and maintain separate copies of the system implemented in thereport-target-prbranch for each use pattern) to provide effective integration test coverage.