Move test data from test code to data files #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test_get_sketches_reports unit test makes assertions of the data the function will return given a set of input report files. Previously, the assertion data was defined in the test code. That was a significant amount of data, which added a lot of code to the test that is not of interest to the test code maintainer. This will become much more problematic if additional variants of the test are added in the future to provide coverage for other conditions. The problem is solved by moving the data to a JSON file. The test loads the data from the file when making the assertion.
per1234
added
type: enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 729 731 +2
=========================================
+ Hits 729 731 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test_get_sketches_reports unit test makes assertions of the data the function will return given a set of input report files. Previously, the assertion data was defined in the test code. That was a significant amount of data, which added a lot of code to the test that is not of interest to the test code maintainer. This will become much more problematic if additional variants of the test are added in the future to provide coverage for other conditions.
The problem is solved by moving the data to a JSON file. The test loads the data from the file when making the assertion.