Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repositories.txt #2233

Merged
merged 4 commits into from
Dec 14, 2022
Merged

Update repositories.txt #2233

merged 4 commits into from
Dec 14, 2022

Conversation

dvarrel
Copy link
Contributor

@dvarrel dvarrel commented Dec 14, 2022

No description provided.

@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/dvarrel/ESP32AsyncTCP.git

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 14, 2022
@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/dvarrel/ESPAsyncTCP.git

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @dvarrel
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@dvarrel
Copy link
Contributor Author

dvarrel commented Dec 14, 2022

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/dvarrel/ESP32AsyncTCP.git:

Linting library in ESP32AsyncTCP
INFO: No header file found matching library name (ESP32AsyncTCP.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

@github-actions
Copy link
Contributor

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 December 14, 2022 07:13
@github-actions github-actions bot removed the request for review from per1234 December 14, 2022 07:23
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/dvarrel/AsyncTCP.git:

Linting library in AsyncTCP
INFO: No header file found matching library name (ESP32AsyncTCP.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

@github-actions
Copy link
Contributor

ERROR: Your submission meets all requirements. However, the pull request could not be merged.

Please follow this guide to resolve a merge conflict:
https://docs.github.com/github/collaborating-with-issues-and-pull-requests/resolving-a-merge-conflict-on-github

Once that is done, it will be merged automatically.

@github-actions github-actions bot requested a review from per1234 December 14, 2022 07:24
@github-actions github-actions bot removed the request for review from per1234 December 14, 2022 07:29
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/dvarrel/AsyncTCP.git:

Linting library in AsyncTCP
INFO: No header file found matching library name (ESP32AsyncTCP.h). Best practices are for primary header filename to   
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

@github-actions github-actions bot merged commit e46e2d1 into arduino:main Dec 14, 2022
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/dvarrel/AsyncTCP/
http://downloads.arduino.cc/libraries/logs/github.com/dvarrel/ESPAsyncTCP/

github-actions bot pushed a commit that referenced this pull request Dec 14, 2022
@per1234 per1234 mentioned this pull request Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: submission Add library to the list
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants