Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace problematic release of github.com/oleiade/reflections dependency #244

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Replace problematic release of github.com/oleiade/reflections dependency #244

merged 1 commit into from
Aug 6, 2021

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Aug 6, 2021

This indirect dependency had a force push that changed the checksum of its v1.0.0 tag
(oleiade/reflections#14). This causes Dependabot to fail, meaning it won't provide any notifications of dependency updates (nor is Dependabot so kind as to provide a notification of such failures):
https://github.com/arduino/arduino-lint/network/updates/180623112

Dependabot can't resolve your Go dependency files
Dependabot failed to update your dependencies because there was an error resolving your Go dependency files.
Dependabot encountered the following error:
verifying github.com/oleiade/reflections@v1.0.0/go.mod: checksum mismatch

There has been a new release of github.com/oleiade/reflections and this is slowly working its way up Arduino Lint's supply chain, but it's still not here. So I am forcing a replacement of the module's v1.0.0 tag with the v1.0.1, which is identical to v1.0.0. This change should be reverted once the supply chain provides github.com/oleiade/reflections@v1.0.1 directly.

…dency

This indirect dependency had a force push that changed the checksum of its v1.0.0. This causes Dependabot to fail,
meaning it won't provide any notifications of dependency updates (nor is Dependabot so kind as to provide a notification
of failures).

There has been a new release of `github.com/oleiade/reflections` and this is slowly working its way up Arduino Lint's
supply chain, but it's still not here. So I am forcing a replacement of the module's v1.0.0 tag with the v1.0.1, which is
identical to v1.0.0. This change should be reverted once the supply chain provides v1.0.1 directly.
@per1234 per1234 added type: bug topic: infrastructure Related to project infrastructure labels Aug 6, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #244 (43caafa) into main (bf7335b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   89.85%   89.85%           
=======================================
  Files          43       43           
  Lines        6320     6320           
=======================================
  Hits         5679     5679           
  Misses        530      530           
  Partials      111      111           
Flag Coverage Δ
unit 89.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf7335b...43caafa. Read the comment docs.

@per1234 per1234 merged commit 47fefe1 into arduino:main Aug 6, 2021
@per1234 per1234 deleted the replace-dep branch August 6, 2021 08:39
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants