Change release filenames and finalize CI #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmoog
reviewed
Jan 12, 2021
Comment on lines
-37
to
+38
| runs-on: ${{ matrix.operating-system }} | ||
| runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
Nice, os is compact and clear 💯
zmoog
reviewed
Jan 12, 2021
Comment on lines
+154
to
+159
| strategy: | ||
| matrix: # to allow support for future architectures | ||
| os: [macos-10.15] | ||
| arch: [-amd64] | ||
|
|
||
| runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
Good, future-proof without over-engineering it.
zmoog
approved these changes
Jan 12, 2021
umbynos
added a commit
that referenced
this pull request
Jan 12, 2021
* change path for s3 sync * add old path for autoupdate (we cannot autoupdate config.ini) * update (and remove "Bridge") from config.ini * fix naming: every os has also arch and general improvements * use arrays in matrix && rename operating-system to os * add step to update version file * uniform test.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Optimizations before 1.2.0 release
Fixes and improvements before 1.2.0 🎉
Release filenames now is consistent (eg
linux-x64and osx without architecture)Change path for s3 sync (removed "Bridge")
Add step to upload file with latest version (used by frontend to trigger autoupdate and to build the name of the installer).
Does this PR introduce a breaking change?