Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert to building minimum version for mac to 10.9 & separate step fo… #576

Merged
merged 1 commit into from
Dec 11, 2020
Merged

revert to building minimum version for mac to 10.9 & separate step fo… #576

merged 1 commit into from
Dec 11, 2020

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Dec 11, 2020

…r mac

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • What kind of change does this PR introduce?

bug fix

  • What is the current behavior?

The agent gives an error when is installed on older version of MacOS

image

  • What is the new behavior?

Minimum mac version lowered to 10.9

  • Does this PR introduce a breaking change?

nope, the agent should stay compatible with every platform as before.

  • Other information:

@umbynos umbynos self-assigned this Dec 11, 2020
@umbynos umbynos added the CI label Dec 11, 2020
@umbynos umbynos requested a review from zmoog December 11, 2020 17:17
zmoog
zmoog approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmoog zmoog merged commit b88987e into devel Dec 11, 2020
@zmoog zmoog deleted the umbynos/fix_mac_old_version branch December 11, 2020 17:22
@umbynos umbynos mentioned this pull request Dec 14, 2020
Merged
6 tasks
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

Assignees

@umbynos umbynos

Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umbynos @zmoog @per1234