Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port installer generation to github actions #562

Merged
merged 60 commits into from
Nov 18, 2020
Merged

Port installer generation to github actions #562

merged 60 commits into from
Nov 18, 2020

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Oct 28, 2020 •
edited
Loading

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

feature

  • What is the current behavior?

The installer generation process at the moment is unusable

  • What is the new behavior?

this PR introduces the ArduinoCreateAgent installers automatic generation using github actions (see release.yml)

The Taskfile.yml includes some improvements like cli build and win build fixes

  • Does this PR introduce a breaking change?

nope

  • Other information:

Maurizio Branca and others added 18 commits October 13, 2020 16:03
@umbynos
Copy link
Contributor Author

umbynos commented Oct 28, 2020

Linux insaller version works! 🥳 You can find the installer in the artifacts in the latest relese/package wokflow run

@umbynos umbynos self-assigned this Oct 28, 2020
@umbynos umbynos added the CI label Oct 29, 2020
@umbynos umbynos force-pushed the umbynos/installers branch from 1314060 to 1d712b9 Compare October 29, 2020 18:15
@umbynos umbynos force-pushed the umbynos/installers branch 4 times, most recently from c6f6112 to 06e1205 Compare October 30, 2020 09:10
@umbynos umbynos force-pushed the umbynos/installers branch from 06e1205 to 05dcf51 Compare October 30, 2020 09:19
@umbynos
fix mac installer generation failure without env variable
dcbfb27 
fix executable on osx was not found by installbuilder
@umbynos umbynos force-pushed the umbynos/installers branch 2 times, most recently from 4852950 to c2f2a53 Compare November 13, 2020 10:25
@umbynos umbynos marked this pull request as ready for review November 16, 2020 12:05
@umbynos umbynos requested a review from zmoog November 17, 2020 10:45
zmoog
zmoog approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥳

@umbynos umbynos merged commit c5e43ba into devel Nov 18, 2020
@umbynos umbynos deleted the umbynos/installers branch November 18, 2020 11:42
@per1234 per1234 added the topic: infrastructure Related to project infrastructure label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 left review comments

@zmoog zmoog zmoog approved these changes

Assignees

@umbynos umbynos

Labels
topic: infrastructure Related to project infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umbynos @zmoog @per1234