-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ci step to upload artifacts #561
Conversation
1ace115
to
bb9e122
Compare
bb9e122
to
6137284
Compare
d94d4f0
to
c74ad14
Compare
This reverts commit c74ad14.
@@ -58,7 +58,7 @@ jobs: | |||
uses: actions/upload-artifact@v2 | |||
with: | |||
name: arduino-create-agent-${{ matrix.operating-system }} | |||
path: arduino-create-agent | |||
path: arduino-create-agent* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
windows executable ends with .exe
extension. Leaving it without the * character ends in the CI failing because it cannot find the correct file to upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's handy to have a reproducible environment to compile the source code
* uniform `test.yml` to `release.yml` * added again #561 for testing purposes * add win64 build in and refactor taskfile * change min supported macOS version to 10.11 (also go 1.14) * hard-code gon config in a step for uniformity and ease * refactor and optimize Taskfile (✨) change also workflows accordingly * add another win CI matrix to build win 32-64 * add win 32/64 to all the jobs in the release workflow & optimizations 🧙🏻
Please check if the PR fulfills these requirements
before creating one)
CI feature
no artifacts is uploaded by the ci
artifacts of the compiled executables are uploaded
no