Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci step to upload artifacts #561

Merged
merged 4 commits into from
Oct 27, 2020
Merged

add ci step to upload artifacts #561

merged 4 commits into from
Oct 27, 2020

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Oct 27, 2020

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

CI feature

  • What is the current behavior?

no artifacts is uploaded by the ci

  • What is the new behavior?

artifacts of the compiled executables are uploaded

  • Does this PR introduce a breaking change?

no

  • Other information:

@@ -58,7 +58,7 @@ jobs:
uses: actions/upload-artifact@v2
with:
name: arduino-create-agent-${{ matrix.operating-system }}
path: arduino-create-agent
path: arduino-create-agent*
Copy link
Contributor Author

@umbynos umbynos Oct 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

windows executable ends with .exe extension. Leaving it without the * character ends in the CI failing because it cannot find the correct file to upload

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zmoog zmoog merged commit 9f3cb8b into devel Oct 27, 2020
@zmoog zmoog deleted the upload-artifacts branch October 27, 2020 12:35
umbynos added a commit that referenced this pull request Dec 14, 2020
It's handy to have a reproducible environment to compile the source code
umbynos added a commit that referenced this pull request Dec 17, 2020
* uniform `test.yml` to `release.yml`

* added again #561 for testing purposes

* add win64 build in and refactor taskfile

* change min supported macOS version to 10.11 (also go 1.14)

* hard-code gon config in a step for uniformity and ease

* refactor and optimize Taskfile (✨) change also workflows accordingly

* add another win CI matrix to build win 32-64

* add win 32/64 to all the jobs in the release workflow & optimizations 🧙🏻
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants