Show similar library names in lib search

[2qar]

Closes #107

Small typos when searching for libraries will show similar library names instead of showing no results.

Emphasis on "small", though, because the similarity value check is hard-coded at a value that's a little strict (maybe this could be a config option?).

[rsora]

Hi @BigHeadGeorge thanks for you contribution!
Sorry for the delayed review 😸 Can you please rebase your PR, so we can review it again and merge it at the speed of light?
Thanks!

[rsora]

Hi @BigHeadGeorge It seems that your last commit passes all the tests, but the commit history has some problems, can you try a rebase again?

Maybe a git rebase --interactive could help in this case.

Thanks again for contributing!

[2qar]

Sorry for the messy commit history! This is my first time rebasing. I'll get it cleaned up real quick.

[rsora]

Nice job with the rebase 😉 thanks!
I want to ask you if you could be so nice to add a unit test for the new logic you added.

It could be something similar to what we did for the debug command (https://github.com/arduino/arduino-cli/blob/master/commands/debug/debug_test.go). You could proceed like this:

1. Extracting a function searchLibrary(req *rpc.LibrarySearchReq ,lm *librariesmanager.LibrariesManager) containing all the search code, and placing it in the same file (commands/lib/search.go).

2. Create a test function in commands/lib/search_test.go that use the searchLibrary function defined above, passing a custom LibrariesManager built using:

• the NewLibraryManager function
• a fake library_index.json placed in a commands/lib/testdata folder.

Here an example of the test structure, I hope it helps a bit:

// file commands/lib/search_test.go
// ..imports..
// This test expects to find a `commands/lib/testdata` folder containing a fake librery_index.json
var customIndexPath = paths.New("testdata", "custom_lib_index")

func TestSearchLibrary(t *testing.T) {
	lm := librariesmanager.NewLibraryManager(customIndexPath, nil)
	lm.LoadIndex()

	req := &rpc.LibrarySearchReq{
		Instance:   &rpc.Instance{Id: 1},
		Query:    (strings.Join(args, "--your test query-- ")),
	}

	resp, err := searchLibrary(req, lm)
        // ...your asserts on the `resp` object...

Thanks again for your time!

[rsora]

We should move this 0.7 as package variable (see what we did here for example https://github.com/arduino/arduino-cli/blob/master/telemetry/telemetry.go#L31).
I think keeping it as a variable is sufficient, as I'm afraid that having it in the configuration file could create confusion.

[rsora]

This is High Quality Contributing ™️ !

FYI, I had to re-run tests for your last commit, because we have a flaky integration test in the telemetry part that we need to take care of.

Excellent work with the testing part!

[2qar]

Thanks for the help throughout the process (especially the rebase, kinda panicked when I saw 20 unrelated commits in my PR)