-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional include paths libs #502
base: master
Are you sure you want to change the base?
Conversation
Thanks @facchinm! I have done some initial testing. There seems to be a problem in the 'Detecting Libraries' build step. Procedure:
The
This is because I expect the builder to create an include in the tool like "-I{path_to_lib}/src/ossdl/include" so that the tools can find the header file of the submodule
Results
More thoughtsHow does library detection work? I think there lies the cause of the problem
A small nit - I notice that changing library.properties does not signal a change of the library to the builder and so a cached version of the library may be used, however if the |
This tries to avoid bundled libraries shadowing other includes
a11f866
to
6058360
Compare
@oclyke |
@facchinm I agree that authors of original libraries should write proper relative includes. But even if every project did that this feature would still be a valuable addition to Arduino -- why? Because now, with a very simple mechanism (git submodules), we can 'symbolically' include and build off of other open-source projects. All the while fighting code duplication, easing maintenance, and more strongly supporting other open-source projects. See, I would not expect the author of an original library to use the |
Could you provide another build to test? |
@SciLor We will end up merging this PR once we get to review it, it shouldn't take long |
@ubidefeo
|
Hi @SciLor. These errors are caused by the use of shell commands that aren't available when using Windows cmd or PowerShell. Fortunately, there is a nice tool called "Git BASH" that is included with Git for Windows. If you have Git installed, you already have it on your computer. If not, you can download it from the official Git website: If you then start |
@per1234 thanks for the hint. Works as charm. |
@SciLor there's no need for arduino-builder.exe. Just use the arduino-cli.exe executable that was generated via The |
@per1234 I can't use arduino-cli as I am using energia (arduino fork) that is still using the arduino-builder. |
Any progress on this? I updated Arduino and have wondered why is my project not compiling anymore. It didn't kept my additional libraries I put to the installation folder. So I thought I will keep the libraries in different folder. What was my surprise as a developer to find out that there is no way to add additional paths... |
do you mean the
which is your installation folder?
you can add additional libraries in |
Is there anything we could do to accelerate merging this one? |
Fixes #501